]> git.madduck.net Git - etc/vim.git/commitdiff

madduck's git repository

Every one of the projects in this repository is available at the canonical URL git://git.madduck.net/madduck/pub/<projectpath> — see each project's metadata for the exact URL.

All patches and comments are welcome. Please squash your changes to logical commits before using git-format-patch and git-send-email to patches@git.madduck.net. If you'd read over the Git project's submission guidelines and adhered to them, I'd be especially grateful.

SSH access, as well as push access can be individually arranged.

If you use my repositories frequently, consider adding the following snippet to ~/.gitconfig and using the third clone URL listed for each project:

[url "git://git.madduck.net/madduck/"]
  insteadOf = madduck:

Fix substitute with `gdefault` on
authorHiroshi Shirosaki <h.shirosaki@gmail.com>
Tue, 5 Jan 2016 05:45:02 +0000 (14:45 +0900)
committerHiroshi Shirosaki <h.shirosaki@gmail.com>
Tue, 5 Jan 2016 05:45:02 +0000 (14:45 +0900)
Do not substitute with `g` flag if `gdefault` is on.
Fix #225
We convert table format tests to varder.

ftplugin/markdown.vim
test/table_format.md [deleted file]
test/table_format.vader [new file with mode: 0644]

index 9b9876779e6b6d62a05c34d550bfac6ccc51fd9c..f68e54c60b22e41a520a60658d637c49d5b7aa46 100644 (file)
@@ -381,8 +381,9 @@ function! s:HeaderDecrease(line1, line2, ...)
         endif
     endfor
     let l:numSubstitutions = s:SetexToAtx(a:line1, a:line2)
+    let l:flags = (&gdefault ? '' : 'g')
     for l:level in range(replaceLevels[0], replaceLevels[1], -l:levelDelta)
-        execute 'silent! ' . a:line1 . ',' . (a:line2 - l:numSubstitutions) . 'substitute/' . s:levelRegexpDict[l:level] . '/' . repeat('#', l:level + l:levelDelta) . '/g'
+        execute 'silent! ' . a:line1 . ',' . (a:line2 - l:numSubstitutions) . 'substitute/' . s:levelRegexpDict[l:level] . '/' . repeat('#', l:level + l:levelDelta) . '/' . l:flags
     endfor
 endfunction
 
@@ -398,9 +399,10 @@ function! s:TableFormat()
     normal! j
     " Remove everything that is not a pipe othewise well formated tables would grow
     " because of addition of 2 spaces on the separator line by Tabularize /|.
-    s/[^|]//g
+    let l:flags = (&gdefault ? '' : 'g')
+    execute 's/[^|]//' . l:flags
     Tabularize /|
-    s/ /-/g
+    execute 's/ /-/' . l:flags
     call setpos('.', l:pos)
 endfunction
 
diff --git a/test/table_format.md b/test/table_format.md
deleted file mode 100644 (file)
index 3b617f0..0000000
+++ /dev/null
@@ -1,17 +0,0 @@
-| normal |no space|  2 spaces  ||
-| - |-|  --- ||
-| normal |no space|  2 spaces  ||
-
-The table above is the first thing in the file.
-
-The following table is already well formatted. It should not be modified:
-
-| a | b |
-|---|---|
-| c | d |
-
-The following table is the last thing in the file:
-
-| normal |no space|  2 spaces  ||
-| - |-|  --- ||
-| normal |no space|  2 spaces  ||
diff --git a/test/table_format.vader b/test/table_format.vader
new file mode 100644 (file)
index 0000000..c29ab03
--- /dev/null
@@ -0,0 +1,31 @@
+Before:
+  let &gdefault = 1
+
+After:
+  let &gdefault = 0
+
+Given markdown;
+| normal |no space|  2 spaces  ||
+| - |-|  --- ||
+| normal |no space|  2 spaces  ||
+
+Execute (format unformatted table):
+  TableFormat
+
+Expect (table is formatted):
+  | normal | no space | 2 spaces |  |
+  |--------|----------|----------|--|
+  | normal | no space | 2 spaces |  |
+
+Given markdown;
+| a | b |
+|---|---|
+| c | d |
+
+Execute (format well formatted table):
+  TableFormat
+
+Expect (table is not modified):
+  | a | b |
+  |---|---|
+  | c | d |