]> git.madduck.net Git - etc/vim.git/commitdiff

madduck's git repository

Every one of the projects in this repository is available at the canonical URL git://git.madduck.net/madduck/pub/<projectpath> — see each project's metadata for the exact URL.

All patches and comments are welcome. Please squash your changes to logical commits before using git-format-patch and git-send-email to patches@git.madduck.net. If you'd read over the Git project's submission guidelines and adhered to them, I'd be especially grateful.

SSH access, as well as push access can be individually arranged.

If you use my repositories frequently, consider adding the following snippet to ~/.gitconfig and using the third clone URL listed for each project:

[url "git://git.madduck.net/madduck/"]
  insteadOf = madduck:

Don't freeze when multiple comments directly precede # fmt: off
authorŁukasz Langa <lukasz@langa.pl>
Thu, 21 Jun 2018 20:29:34 +0000 (13:29 -0700)
committerŁukasz Langa <lukasz@langa.pl>
Thu, 21 Jun 2018 21:03:01 +0000 (14:03 -0700)
Fixes #371

README.md
black.py
tests/data/fmtonoff.py

index c93c3003ff08c5966ba40aa9933e2c63d814a0df..96d169a2118d3ad237e60b6fe51713331dafbfb7 100644 (file)
--- a/README.md
+++ b/README.md
@@ -820,6 +820,11 @@ More details can be found in [CONTRIBUTING](CONTRIBUTING.md).
 
 ## Change Log
 
+### 18.6b4
+
+* hotfix: don't freeze when multiple comments directly precede `# fmt: off` (#371)
+
+
 ### 18.6b3
 
 * typing stub files (`.pyi`) now have blank lines added after constants (#340)
index 0da2fad34a98422e732415776e893d98916209cf..2d23298e9c9ec65781f5c02f96794181bd9972d7 100644 (file)
--- a/black.py
+++ b/black.py
@@ -2608,7 +2608,7 @@ def convert_one_fmt_off_pair(node: Node) -> bool:
                 )
                 return True
 
-            previous_consumed += comment.consumed
+            previous_consumed = comment.consumed
 
     return False
 
index 74b52ec28e05ac4793a283ef5c6bdeba8285cce3..b2e9fc0ad97b755d366faad076a3e67721f02cb8 100644 (file)
@@ -11,6 +11,10 @@ from third_party import (X,
                          Y, Z)
 # fmt: on
 f'trigger 3.6 mode'
+# Comment 1
+
+# Comment 2
+
 # fmt: off
 def func_no_args():
   a; b; c
@@ -159,6 +163,10 @@ from third_party import (X,
                          Y, Z)
 # fmt: on
 f"trigger 3.6 mode"
+# Comment 1
+
+# Comment 2
+
 # fmt: off
 def func_no_args():
   a; b; c