]> git.madduck.net Git - etc/vim.git/log

madduck's git repository

Every one of the projects in this repository is available at the canonical URL git://git.madduck.net/madduck/pub/<projectpath> — see each project's metadata for the exact URL.

All patches and comments are welcome. Please squash your changes to logical commits before using git-format-patch and git-send-email to patches@git.madduck.net. If you'd read over the Git project's submission guidelines and adhered to them, I'd be especially grateful.

SSH access, as well as push access can be individually arranged.

If you use my repositories frequently, consider adding the following snippet to ~/.gitconfig and using the third clone URL listed for each project:

[url "git://git.madduck.net/madduck/"]
  insteadOf = madduck:

etc/vim.git
6 years agowrap atoms in invisible parens to split adjacent strings (#463)
Jelle Zijlstra [Wed, 22 Aug 2018 04:10:59 +0000 (21:10 -0700)]
wrap atoms in invisible parens to split adjacent strings (#463)

6 years agoMerge pull request #71 from TomasFlam/pr-allow-flake8-cmd-with-parameters
Vincent Driessen [Tue, 21 Aug 2018 14:36:31 +0000 (16:36 +0200)]
Merge pull request #71 from TomasFlam/pr-allow-flake8-cmd-with-parameters

Allow g:flake8_cmd with parameters

6 years agoAllow g:flake8_cmd with parameters
Tomas Flam [Tue, 21 Aug 2018 14:12:27 +0000 (16:12 +0200)]
Allow g:flake8_cmd with parameters

6 years agofix misformatting of floats with leading zeros (#464)
Jelle Zijlstra [Mon, 20 Aug 2018 15:19:25 +0000 (08:19 -0700)]
fix misformatting of floats with leading zeros (#464)

6 years agoSupport parsing of async generators in non-async functions (#165)
Zsolt Dollenstein [Mon, 20 Aug 2018 13:47:58 +0000 (14:47 +0100)]
Support parsing of async generators in non-async functions (#165)

This is a new syntax added in python3.7, so black can't verify that reformatting will not change the ast unless black itself is run with 3.7. We'll need to change the error message black gives in this case. @ambv any ideas?

Fixes #125.

6 years agoautodetect Python 3.6 on the basis of underscores (#461)
Jelle Zijlstra [Mon, 20 Aug 2018 04:02:06 +0000 (21:02 -0700)]
autodetect Python 3.6 on the basis of underscores (#461)

6 years agoFix minor typos (#443)
ceh [Sun, 19 Aug 2018 12:10:06 +0000 (14:10 +0200)]
Fix minor typos (#443)

6 years agocommitters += jelle
Łukasz Langa [Sat, 18 Aug 2018 21:01:57 +0000 (14:01 -0700)]
committers += jelle

6 years agoPyPI downloads badge
Łukasz Langa [Fri, 17 Aug 2018 17:59:32 +0000 (10:59 -0700)]
PyPI downloads badge

6 years agoNits around numeral normalization.
Łukasz Langa [Fri, 17 Aug 2018 17:38:28 +0000 (10:38 -0700)]
Nits around numeral normalization.

6 years agoPut missing blank lines after return statements.
Łukasz Langa [Fri, 17 Aug 2018 17:29:19 +0000 (10:29 -0700)]
Put missing blank lines after return statements.

6 years agoMake schedule_formatting logic less nested.
Łukasz Langa [Fri, 17 Aug 2018 17:17:37 +0000 (10:17 -0700)]
Make schedule_formatting logic less nested.

6 years agoSimplify caching logic.
Łukasz Langa [Fri, 17 Aug 2018 17:14:10 +0000 (10:14 -0700)]
Simplify caching logic.

6 years agoUpdate README with missing change log, etc.
Łukasz Langa [Fri, 17 Aug 2018 17:11:01 +0000 (10:11 -0700)]
Update README with missing change log, etc.

6 years agonot enforcing python3.6 for precommit hook (#430)
Miroslav Shubernetskiy [Fri, 17 Aug 2018 16:01:29 +0000 (12:01 -0400)]
not enforcing python3.6 for precommit hook (#430)

this should allow precommit hooks to be used with py37

6 years agoRemove mappings from Vim plugin. (#417)
David Hotham [Fri, 17 Aug 2018 15:45:47 +0000 (16:45 +0100)]
Remove mappings from Vim plugin. (#417)

They clashed with standard mappings.  Simplest just to let users define
their own.

Fixes #415

6 years agoadded instructions for PyCharm File Watcher setup (#418)
Benjamin Wohlwend [Fri, 17 Aug 2018 15:44:55 +0000 (17:44 +0200)]
added instructions for PyCharm File Watcher setup (#418)

* added instructions for PyCharm File Watcher setup

With these steps, PyCharm will run black on every file save.

* Update README.md

6 years agovim: Restore cursor/window position after format (#433)
Jonty Wareing [Fri, 17 Aug 2018 15:39:34 +0000 (16:39 +0100)]
vim: Restore cursor/window position after format (#433)

Without this the cursor jumps to the top of the window after formatting
occurs.

6 years agoAdd playground link (#437)
José Padilla [Fri, 17 Aug 2018 15:36:57 +0000 (11:36 -0400)]
Add playground link (#437)

6 years agoUse atom-black plugin for Atom integration (#456)
hauntsaninja [Fri, 17 Aug 2018 15:25:47 +0000 (08:25 -0700)]
Use atom-black plugin for Atom integration (#456)

6 years agowrite cache in --check mode (#453)
Jelle Zijlstra [Fri, 17 Aug 2018 14:40:37 +0000 (07:40 -0700)]
write cache in --check mode (#453)

Fixes #448.

This diff makes us always write to the cache in normal mode, except
if the file is already in the cache, and it makes us write to the
cache in --check mode if the file is already well formatted.

I also fixed some related docstrings.

WriteBack.NO is now used only in tests.

6 years agonormalize numeric literals (#454)
Jelle Zijlstra [Fri, 17 Aug 2018 14:03:58 +0000 (07:03 -0700)]
normalize numeric literals (#454)

Fixes #452

I ended up making a couple of other normalizations to numeric literals
too (lowercase everything, don't allow leading or trailing . in floats,
remove redundant + sign in exponent). I don't care too much about those,
so I'm happy to change the behavior there.

For reference, here is Python's grammar for numeric literals:
https://docs.python.org/3/reference/lexical_analysis.html#numeric-literals

6 years agoAdd basic usage in table of contents
Hiroshi Shirosaki [Mon, 30 Jul 2018 00:45:20 +0000 (09:45 +0900)]
Add basic usage in table of contents

6 years agoAdd basic usage for fold and conceal #334
Hiroshi Shirosaki [Mon, 30 Jul 2018 00:40:56 +0000 (09:40 +0900)]
Add basic usage for fold and conceal #334

6 years agoRemove easy_install on travis
Hiroshi Shirosaki [Fri, 27 Jul 2018 13:53:57 +0000 (22:53 +0900)]
Remove easy_install on travis

get-pip.py installs pip.

6 years agoHandle byte strings in s:skip_special_chars (#113)
Daniel Hahler [Thu, 26 Jul 2018 09:04:30 +0000 (11:04 +0200)]
Handle byte strings in s:skip_special_chars (#113)

Fixes https://github.com/Vimjas/vim-python-pep8-indent/issues/72.
Closes https://github.com/Vimjas/vim-python-pep8-indent/pull/71.
Closes https://github.com/Vimjas/vim-python-pep8-indent/pull/68.

6 years agoRemove bit about authors from contributing guide
Fergal Hainey [Sun, 22 Jan 2017 13:17:37 +0000 (13:17 +0000)]
Remove bit about authors from contributing guide

This is now tracked by GitHub

6 years agoAdd Gemfile.lock to .gitignore
Fergal Hainey [Fri, 20 Jan 2017 15:23:34 +0000 (15:23 +0000)]
Add Gemfile.lock to .gitignore

6 years agoMerge pull request #112 from blueyed/fix-97
Daniel Hahler [Thu, 26 Jul 2018 08:03:04 +0000 (10:03 +0200)]
Merge pull request #112 from blueyed/fix-97

Fix indenting of "else" with outer if

6 years agoSimplify s:find_start_of_block
Daniel Hahler [Thu, 26 Jul 2018 07:56:26 +0000 (09:56 +0200)]
Simplify s:find_start_of_block

6 years agoFix indenting of "else" with outer if
Daniel Hahler [Thu, 26 Jul 2018 07:35:30 +0000 (09:35 +0200)]
Fix indenting of "else" with outer if

Fixes https://github.com/Vimjas/vim-python-pep8-indent/issues/97.

6 years agoFix multiline handling with blank lines (#111)
Daniel Hahler [Thu, 26 Jul 2018 07:26:18 +0000 (09:26 +0200)]
Fix multiline handling with blank lines (#111)

6 years agoFix test for heading highlight
Hiroshi Shirosaki [Thu, 26 Jul 2018 05:48:51 +0000 (14:48 +0900)]
Fix test for heading highlight

Head # is `mkdHeading` syntax. Remove # from SytanxOf().
Fix #370

6 years agoAdd heading highlight group
Jerome Dalbert [Sun, 8 Apr 2018 16:42:47 +0000 (09:42 -0700)]
Add heading highlight group

6 years agoUpdate doc
Hiroshi Shirosaki [Thu, 26 Jul 2018 05:40:20 +0000 (14:40 +0900)]
Update doc

6 years agoMerge pull request #371 from codybuell/master
Hiroshi Shirosaki [Thu, 26 Jul 2018 05:37:10 +0000 (14:37 +0900)]
Merge pull request #371 from codybuell/master

Add support for opening links in tabs and splits

6 years agoMerge branch 'master' into master
Hiroshi Shirosaki [Thu, 26 Jul 2018 05:36:42 +0000 (14:36 +0900)]
Merge branch 'master' into master

6 years agoMerge pull request #375 from anowlcalledjosh/auto-insert-bullets
Hiroshi Shirosaki [Thu, 26 Jul 2018 05:11:29 +0000 (14:11 +0900)]
Merge pull request #375 from anowlcalledjosh/auto-insert-bullets

Add option to disable automatic bullet insertion

6 years agoMerge pull request #377 from mmFooD/code-conceal
Hiroshi Shirosaki [Thu, 26 Jul 2018 05:07:43 +0000 (14:07 +0900)]
Merge pull request #377 from mmFooD/code-conceal

Added concealends for code items

6 years agoMerge pull request #374 from anowlcalledjosh/yaml-triple-dot
Hiroshi Shirosaki [Thu, 26 Jul 2018 04:56:39 +0000 (13:56 +0900)]
Merge pull request #374 from anowlcalledjosh/yaml-triple-dot

Support YAML frontmatter that ends with "..."

6 years agofixed "feature" to not fold level 1 headings
Joedang [Thu, 26 Jul 2018 02:07:32 +0000 (19:07 -0700)]
fixed "feature" to not fold level 1 headings

I also added comments explaining some of the code in that section, for
my own benefit.

6 years agoRemove dead s:pair_pos (#108)
Daniel Hahler [Tue, 24 Jul 2018 23:33:45 +0000 (01:33 +0200)]
Remove dead s:pair_pos (#108)

Its usage was removed in 782b0f0.

6 years agoMerge pull request #110 from blueyed/v8.1.0129
Daniel Hahler [Tue, 24 Jul 2018 23:23:28 +0000 (01:23 +0200)]
Merge pull request #110 from blueyed/v8.1.0129

tests: use Vim v8.1.0129 to work around Vim bug

6 years agoFix cython tests that successful due to Vim segfaulting and vimrunner not handling it
Daniel Hahler [Tue, 24 Jul 2018 23:19:51 +0000 (01:19 +0200)]
Fix cython tests that successful due to Vim segfaulting and vimrunner not handling it

6 years agotests: use Vim v8.1.0129 to work around Vim bug
Daniel Hahler [Tue, 24 Jul 2018 22:59:20 +0000 (00:59 +0200)]
tests: use Vim v8.1.0129 to work around Vim bug

This works around a segfault with profiling.

Ref: https://github.com/vim/vim/commit/ad6480961080f80a455b2394f27b02935a2ded52#commitcomment-29790223

6 years agoREADME: update badges: CircleCI/Codecov
Daniel Hahler [Sun, 22 Jul 2018 21:59:18 +0000 (23:59 +0200)]
README: update badges: CircleCI/Codecov

6 years agoAddress Flake8's E127 with "if (" (#102)
Daniel Hahler [Sun, 22 Jul 2018 21:54:26 +0000 (23:54 +0200)]
Address Flake8's E127 with "if (" (#102)

> continuation line over-indented for visual indent

It appears that the "if (" is just the 4 columns wide that triggers the
extra indent with sw=4.

Might also change/adjust b:control_statement to ignore `if (`, but this
appears to be more flexible/correct.

6 years agoLook at actual parenthesis when generating ignored leafs.
Zsolt Dollenstein [Sun, 22 Jul 2018 13:47:42 +0000 (14:47 +0100)]
Look at actual parenthesis when generating ignored leafs.

Fixes #385

6 years agotests: fix vim.kill: use <CR> (#109)
Daniel Hahler [Sat, 21 Jul 2018 20:22:15 +0000 (22:22 +0200)]
tests: fix vim.kill: use <CR> (#109)

6 years agoCoverage reporting via covimerage (#107)
Daniel Hahler [Sat, 21 Jul 2018 20:07:45 +0000 (22:07 +0200)]
Coverage reporting via covimerage (#107)

This splits out the tests for cython, since the runtime file gets
reloaded for them, and that resets profiling information.

6 years ago- make brightblue in dark background a bit darker
Stefan Wimmer [Sat, 21 Jul 2018 14:05:21 +0000 (16:05 +0200)]
- make brightblue in dark background a bit darker

6 years ago- upstream update for terminal colours
Stefan Wimmer [Sat, 21 Jul 2018 13:48:39 +0000 (15:48 +0200)]
- upstream update for terminal colours
- add more blue to the dark backgrounds

6 years agoUse Docker for easier test running (#86)
Daniel Hahler [Sat, 21 Jul 2018 07:02:47 +0000 (09:02 +0200)]
Use Docker for easier test running (#86)

Switches to CircleCI instead of Travis, which handles running tests in
Docker much better, especially since Travis is really slow (~30min vs
2.5min on CircleCI).

The Docker image is based on
https://github.com/tweekmonster/vim-testbed, and targets are added to
the Makefile to build/push it.

6 years agoupdate to mypy 0.620 and make tests pass again
Zsolt Dollenstein [Wed, 18 Jul 2018 21:07:54 +0000 (22:07 +0100)]
update to mypy 0.620 and make tests pass again

Fixes #408

6 years agotests: remove nil from hang-closing tests (#105)
Daniel Hahler [Tue, 17 Jul 2018 22:37:40 +0000 (00:37 +0200)]
tests: remove nil from hang-closing tests (#105)

There is not much value in running all tests with it to see that the
default is used.

6 years agoTravis: do not pin rvm (#103)
Daniel Hahler [Mon, 16 Jul 2018 18:02:16 +0000 (20:02 +0200)]
Travis: do not pin rvm (#103)

6 years agoTravis: remove vint for now
Daniel Hahler [Mon, 16 Jul 2018 18:00:35 +0000 (20:00 +0200)]
Travis: remove vint for now

It is always failing, not worth fixing for now.

Ref: https://github.com/Kuniwak/vint/pull/288
Ref: https://github.com/Kuniwak/vint/issues/287

6 years agoGemfile: update vimrunner to 0.3.4 (#104)
Daniel Hahler [Mon, 16 Jul 2018 17:55:51 +0000 (19:55 +0200)]
Gemfile: update vimrunner to 0.3.4 (#104)

6 years agoREADME: add Troubleshooting section
Daniel Hahler [Sun, 15 Jul 2018 19:31:38 +0000 (21:31 +0200)]
README: add Troubleshooting section

Fixes https://github.com/Vimjas/vim-python-pep8-indent/issues/75.

6 years agoAdd option for hanging closing brackets (#94)
Jake Harr [Sun, 15 Jul 2018 19:11:26 +0000 (15:11 -0400)]
Add option for hanging closing brackets (#94)

The main idea is discussed at length in PyCQA/pycodestyle#103.

* Add tests for `python_pep8_indent_hang_closing`

This might be overkill. It reruns the current "vim" set of tests once
for each value of the new setting. Of course, this makes the test suite
take longer to run. I couldn't think of a good way to factor out the
relevant test cases without creating a mess.

6 years agopre-commit: use exclusion instead of ever-growing regex (#382)
Anthony Sottile [Mon, 9 Jul 2018 20:42:38 +0000 (13:42 -0700)]
pre-commit: use exclusion instead of ever-growing regex (#382)

6 years agoadd change log entry
Zsolt Dollenstein [Mon, 2 Jul 2018 17:02:13 +0000 (18:02 +0100)]
add change log entry

6 years agoImprove get_future_imports implementation.
Zsolt Dollenstein [Mon, 2 Jul 2018 16:48:48 +0000 (17:48 +0100)]
Improve get_future_imports implementation.

Closes #389.

6 years agoTravisCI: Test on production Python 3.7 and 3.8-dev (#393)
cclauss [Mon, 2 Jul 2018 16:05:40 +0000 (18:05 +0200)]
TravisCI: Test on production Python 3.7 and 3.8-dev (#393)

6 years agoSuggest BufWritePre instead of BufWritePost for vi (#376)
David Szotten [Sat, 23 Jun 2018 07:56:05 +0000 (08:56 +0100)]
Suggest BufWritePre instead of BufWritePost for vi (#376)

closes #321

6 years ago18.6b4
Łukasz Langa [Thu, 21 Jun 2018 21:25:07 +0000 (14:25 -0700)]
18.6b4

6 years agoDon't freeze when multiple comments directly precede # fmt: off
Łukasz Langa [Thu, 21 Jun 2018 20:29:34 +0000 (13:29 -0700)]
Don't freeze when multiple comments directly precede # fmt: off

Fixes #371

6 years ago18.6b3
Łukasz Langa [Wed, 20 Jun 2018 19:00:07 +0000 (12:00 -0700)]
18.6b3

6 years agoMore tests for `# fmt: off`
Łukasz Langa [Wed, 20 Jun 2018 06:46:58 +0000 (23:46 -0700)]
More tests for `# fmt: off`

Two more known limitations that I don't feel like solving now.  Probably very
low priority.

6 years agoTrivial nits
Łukasz Langa [Wed, 20 Jun 2018 06:08:10 +0000 (23:08 -0700)]
Trivial nits

6 years agoStop Click from crashing Black on invalid environments
Łukasz Langa [Wed, 20 Jun 2018 05:40:26 +0000 (22:40 -0700)]
Stop Click from crashing Black on invalid environments

Fixes #277

6 years agoMove INDENT value to the postponed prefix
Łukasz Langa [Wed, 20 Jun 2018 03:44:47 +0000 (20:44 -0700)]
Move INDENT value to the postponed prefix

This makes blib2to3's tree output valid again (which was broken by the previous
fiddling with INDENT and DEDENT nodes).

Fixes #334

6 years agoUse the separate pass for `# fmt: off` on all code
Łukasz Langa [Wed, 20 Jun 2018 00:32:41 +0000 (17:32 -0700)]
Use the separate pass for `# fmt: off` on all code

This removes the hacky exception-based handling that didn't work across
statement boundaries.

Fixes #335

6 years agoSupport `# fmt: off/on` pairs within brackets
Łukasz Langa [Tue, 19 Jun 2018 01:14:10 +0000 (18:14 -0700)]
Support `# fmt: off/on` pairs within brackets

Fixes #329

6 years agoUpdate README with missing fixes in Change Log
Łukasz Langa [Mon, 18 Jun 2018 23:18:45 +0000 (16:18 -0700)]
Update README with missing fixes in Change Log

6 years agoCache generated comments
Łukasz Langa [Mon, 18 Jun 2018 23:14:58 +0000 (16:14 -0700)]
Cache generated comments

6 years agoAdd travis badge and GitHub Fork banner to docs (#365)
Mariatta [Tue, 19 Jun 2018 03:12:49 +0000 (20:12 -0700)]
Add travis badge and GitHub Fork banner to docs (#365)

6 years agoAdd pyls-black to README (#361)
Rupert Bedford [Sat, 16 Jun 2018 20:14:51 +0000 (21:14 +0100)]
Add pyls-black to README (#361)

6 years agoAdd blank line after constants in stub file (#360)
Jelle Zijlstra [Sat, 16 Jun 2018 18:53:45 +0000 (11:53 -0700)]
Add blank line after constants in stub file (#360)

Fixes #340

6 years agoAdd code snippet for using black badge in .rst (#356)
Mariatta [Fri, 15 Jun 2018 22:12:16 +0000 (15:12 -0700)]
Add code snippet for using black badge in .rst (#356)

6 years agoHarmonise with other instances (#347)
Katrin Leinweber [Wed, 13 Jun 2018 18:49:47 +0000 (20:49 +0200)]
Harmonise with other instances (#347)

6 years agoIgnore symbolic links pointing outside of the root directory (#339)
Neraste [Wed, 13 Jun 2018 07:07:04 +0000 (09:07 +0200)]
Ignore symbolic links pointing outside of the root directory (#339)

Fixes #338

6 years agoRemove reference to deprecated Visual Studio Code extension (#343)
Joseph Larson [Tue, 12 Jun 2018 20:36:55 +0000 (14:36 -0600)]
Remove reference to deprecated Visual Studio Code extension (#343)

6 years agoExclude profiling data when doing black . in this repo
Zsolt Dollenstein [Sun, 10 Jun 2018 08:51:18 +0000 (09:51 +0100)]
Exclude profiling data when doing black . in this repo

6 years agoFix string normalization eating all backslashes above 3
Zsolt Dollenstein [Sun, 10 Jun 2018 08:39:24 +0000 (09:39 +0100)]
Fix string normalization eating all backslashes above 3

6 years agoAdd failing test data
Łukasz Langa [Sun, 10 Jun 2018 06:27:00 +0000 (23:27 -0700)]
Add failing test data

6 years agoDon't mark subtrees as changed that were already marked.
Łukasz Langa [Sun, 10 Jun 2018 02:49:20 +0000 (19:49 -0700)]
Don't mark subtrees as changed that were already marked.

6 years agoCache child sibling lookups
Łukasz Langa [Sun, 10 Jun 2018 01:50:20 +0000 (18:50 -0700)]
Cache child sibling lookups

Removes catastrophically quadratic behavior on nodes with very many siblings.

6 years agoMake test_black.py work in profilers
Łukasz Langa [Sun, 10 Jun 2018 01:49:39 +0000 (18:49 -0700)]
Make test_black.py work in profilers

6 years agoMake `is_complex_subscript()` ignore list literals
Łukasz Langa [Sat, 9 Jun 2018 22:40:39 +0000 (15:40 -0700)]
Make `is_complex_subscript()` ignore list literals

This fixes catastrophically quadratic behavior on long lists.

6 years agoMove profiling data out of tests/data
Łukasz Langa [Sat, 9 Jun 2018 22:40:00 +0000 (15:40 -0700)]
Move profiling data out of tests/data

6 years agoFix string normalization sometimes producing invalid fstrings (#327)
Zsolt Dollenstein [Sat, 9 Jun 2018 19:30:49 +0000 (21:30 +0200)]
Fix string normalization sometimes producing invalid fstrings (#327)

6 years agoAdd .toml from tests to MANIFEST.in (#325)
Daniel M. Capella [Sat, 9 Jun 2018 05:02:35 +0000 (01:02 -0400)]
Add .toml from tests to MANIFEST.in (#325)

Needed for `test_piping_diff()`.

6 years ago18.6b2
Łukasz Langa [Fri, 8 Jun 2018 19:07:43 +0000 (12:07 -0700)]
18.6b2

6 years agoUpdate README with missing Change Log entries
Łukasz Langa [Fri, 8 Jun 2018 19:05:44 +0000 (12:05 -0700)]
Update README with missing Change Log entries

6 years agoReturn early from comment placement calculation on lines without comments
Łukasz Langa [Fri, 8 Jun 2018 18:59:05 +0000 (11:59 -0700)]
Return early from comment placement calculation on lines without comments

6 years agoAdd `-h` as a shortcut for `--help` (#316)
Loren Carvalho [Fri, 8 Jun 2018 02:43:04 +0000 (21:43 -0500)]
Add `-h` as a shortcut for `--help` (#316)

6 years agofix handling of empty triple quoted strings (#314)
Zsolt Dollenstein [Thu, 7 Jun 2018 18:41:34 +0000 (20:41 +0200)]
fix handling of empty triple quoted strings (#314)

6 years agoDon't crash the Vim plugin
Łukasz Langa [Thu, 7 Jun 2018 18:40:41 +0000 (11:40 -0700)]
Don't crash the Vim plugin

Fixes #312

6 years ago2018 is not the year of Unicode on your desktop
Łukasz Langa [Thu, 7 Jun 2018 18:24:55 +0000 (11:24 -0700)]
2018 is not the year of Unicode on your desktop