allow aliases to override defined commands

[code/myrepos.git] / mr

diff --git a/mr b/mr
index 856de11f4121f112f9377d6f308096ef5c091248..01a9feb6ae1001e8c97258423832202fd25f4e82 100755 (executable)
--- a/mr
+++ b/mr
@@ -120,11 +120,22 @@ registers several additional repositories.
 
 The .mrconfig file uses a variant of the INI file format. Lines starting with
 "#" are comments. Lines ending with "\" are continued on to the next line.
-Sections specify where each repository is located, relative to the
+
+The "default" section allows setting default values for the sections that
+come after it.
+
+The "alias" section allows adding aliases for actions. Each parameter
+is an alias, and its value is the action to use.
+
+All other sections specify where each repository is located, relative to the
 directory that contains the .mrconfig file.
 
 Within a section, each parameter defines a shell command to run to handle a
-given action. Note that these shell commands are run in a "set -e" shell
+given action. mr contains default handlers for the "update", "status", and
+"commit" actions, so normally you only need to specify what to do for
+"checkout".
+
+Note that these shell commands are run in a "set -e" shell
 environment, where any additional parameters you pass are available in
 "$@". The "checkout" command is run in the parent of the repository
 directory, since the repository isn't checked out yet. All other commands
@@ -141,14 +152,6 @@ should avoid chaining from repositories with untrusted committers.) The
 command, this can be a useful way to define shell functions for other commands
 to use.
 
-The "default" section allows setting up default handlers for each action,
-and is overridden by the contents of other sections. mr contains default
-handlers for the "update", "status", and "commit" actions, so normally
-you only need to specify what to do for "checkout".
-
-The "alias" section allows adding aliases for actions. Each parameter
-is an alias, and its value is the action to use.
-
 For example:
 
   [src]
@@ -215,24 +218,22 @@ eval {
 
 # alias expansion and command stemming
 my $action=shift @ARGV;
+if (exists $alias{$action}) {
+       $action=$alias{$action};
+}
 if (! exists $knownactions{$action}) {
-       if (exists $alias{$action}) {
-               $action=$alias{$action};
+       my @matches = grep { /^\Q$action\E/ }
+               keys %knownactions, keys %alias;
+       if (@matches == 1) {
+               $action=$matches[0];
+       }
+       elsif (@matches == 0) {
+               die "mr: unknown action \"$action\" (known actions: ".
+                       join(", ", sort keys %knownactions).")\n";
        }
        else {
-               my @matches = grep { /^\Q$action\E/ }
-                       keys %knownactions, keys %alias;
-               if (@matches == 1) {
-                       $action=$matches[0];
-               }
-               elsif (@matches == 0) {
-                       die "mr: unknown action \"$action\" (known actions: ".
-                               join(", ", sort keys %knownactions).")\n";
-               }
-               else {
-                       die "mr: ambiguous action \"$action\" (matches: ".
-                               join(", ", @matches).")\n";
-               }
+               die "mr: ambiguous action \"$action\" (matches: ".
+                       join(", ", @matches).")\n";
        }
 }
 
@@ -295,21 +296,23 @@ sub action {
        }
        
        $ENV{MR_REPO}=$dir;
-       if (! $nochdir && ! chdir($dir)) {
-               print STDERR "mr $action: failed to chdir to $dir: $!\n";
-               push @skipped, $dir;
-       }
 
        if (exists $config{$topdir}{$subdir}{skip}) {
-               my $ret=system($lib.$config{$topdir}{$subdir}{skip});
+               my $test="set -e;".$lib.$config{$topdir}{$subdir}{skip};
+               print "mr $action: running skip test $test\n" if $verbose;
+               my $ret=system($test);
                if ($ret >> 8 == 0) {
                        print "mr $action: $dir skipped per config file\n" if $verbose;
                        push @skipped, $dir;
                        return;
                }
        }
-
-       if (! exists $config{$topdir}{$subdir}{$action}) {
+       
+       if (! $nochdir && ! chdir($dir)) {
+               print STDERR "mr $action: failed to chdir to $dir: $!\n";
+               push @failed, $dir;
+       }
+       elsif (! exists $config{$topdir}{$subdir}{$action}) {
                print STDERR "mr $action: no defined $action command for $topdir$subdir, skipping\n";
                push @skipped, $dir;
        }
@@ -468,12 +471,14 @@ __DATA__
        co = checkout
        ci = commit
        ls = list
+
 [default]
 lib = \
        error() { \
                echo "mr: $@" >&2; \
                exit 1; \
        }
+
 update = \
        if [ -d "$MR_REPO"/.svn ]; then \
                svn update "$@"; \
@@ -525,9 +530,13 @@ log = \
                error "unknown repo type"; \
        fi
 list = true
+
 help = \
        if [ ! -e "$MR_PATH" ]; then \
                error "cannot find program path";\
        fi; \
        (pod2man -c mr "$MR_PATH" | man -l -) || \
                error "pod2man or man failed"
+
+ed = echo "A horse is a horse, of course, of course.."
+T = echo "I pity the fool."