* Add a warning about runing too many jobs at a time.

[code/myrepos.git] / mr

diff --git a/mr b/mr
index a4469e9cf4506721f92e644e5702f9b81d3ed465..8cfe01365a9994895430e2dbe714eb2b4cdb00b0 100755 (executable)
--- a/mr
+++ b/mr
@@ -161,11 +161,15 @@ If a number is specified, will recurse into repositories at most that many
 subdirectories deep. For example, with -n 2 it would recurse into ./src/foo,
 but not ./src/packages/bar.
 
 subdirectories deep. For example, with -n 2 it would recurse into ./src/foo,
 but not ./src/packages/bar.
 

-=item -j number
+=item -j [number]

 
 

-Run the specified number of jobs in parallel. This can greatly speed up
-operations such as updates. It is not recommended for interactive
-operations.
+Run the specified number of jobs in parallel, or an unlimited number of jobs
+with no number specified. This can greatly speed up operations such as updates.
+It is not recommended for interactive operations.
+
+Note that running more than 10 jobs at a time is likely to run afoul of
+ssh connection limits. Running between 3 and 5 jobs at a time will yeild
+a good speedup in updates without loading the machine too much.

 
 =back
 
 
 =back
 


@@ -510,7 +514,7 @@ sub mrs { #{{{
        my @out;
        my $running=0;
        while (@fhs or @repos) {
        my @out;
        my $running=0;
        while (@fhs or @repos) {

-               while ($running < $jobs && @repos) {
+               while ((!$jobs || $running < $jobs) && @repos) {

                        $running++;
                        my $repo = shift @repos;
                        pipe(my $outfh, CHILD_STDOUT);
                        $running++;
                        my $repo = shift @repos;
                        pipe(my $outfh, CHILD_STDOUT);


@@ -928,7 +932,7 @@ sub dispatch { #{{{
                register(@ARGV);
        }
 
                register(@ARGV);
        }
 

-       if ($jobs > 1) {
+       if (!$jobs || $jobs > 1) {

                mrs($action, selectrepos());
        }
        else {
                mrs($action, selectrepos());
        }
        else {


@@ -1052,7 +1056,7 @@ sub getopts { #{{{
                "v|verbose" => \$verbose,
                "s|stats" => \$stats,
                "n|no-recurse:i" => \$max_depth,
                "v|verbose" => \$verbose,
                "s|stats" => \$stats,
                "n|no-recurse:i" => \$max_depth,

-               "j|jobs=i" => \$jobs,
+               "j|jobs:i" => \$jobs,

        );
        if (! $result || @ARGV < 1) {
                die("Usage: mr [-d directory] action [params ...]\n".
        );
        if (! $result || @ARGV < 1) {
                die("Usage: mr [-d directory] action [params ...]\n".