clarify

[code/myrepos.git] / mr

diff --git a/mr b/mr
index a431e8ac82ac989fdbfe1e5b1231e449d8508682..e01ca1f343423a853886184ece27e0895d14bb84 100755 (executable)
--- a/mr
+++ b/mr
@@ -383,7 +383,7 @@ due to being offline. You can delete or edit this file to remove commands,
 or even to add other commands for 'mr online' to run. If the file is
 present, mr assumes it is in offline mode.
 
 or even to add other commands for 'mr online' to run. If the file is
 present, mr assumes it is in offline mode.
 

-=head "UNTRUSTED MRCONFIG FILES"
+=head1 "UNTRUSTED MRCONFIG FILES"

 
 Since mrconfig files can contain arbitrary shell commands, they can do
 anything. This flexability is good, but it also allows a malicious mrconfig
 
 Since mrconfig files can contain arbitrary shell commands, they can do
 anything. This flexability is good, but it also allows a malicious mrconfig


@@ -707,7 +707,7 @@ sub record {
 
        if ($ret == OK) {
                push @ok, $dir;
 
        if ($ret == OK) {
                push @ok, $dir;

-               print "\n";
+               print "\n" unless $quiet;

        }
        elsif ($ret == FAILED) {
                if ($interactive) {
        }
        elsif ($ret == FAILED) {
                if ($interactive) {


@@ -716,7 +716,7 @@ sub record {
                        system((getpwuid($<))[8], "-i");
                }
                push @failed, $dir;
                        system((getpwuid($<))[8], "-i");
                }
                push @failed, $dir;

-               print "\n";
+               print "\n" unless $quiet;

        }
        elsif ($ret == SKIPPED) {
                push @skipped, $dir;
        }
        elsif ($ret == SKIPPED) {
                push @skipped, $dir;


@@ -1001,7 +1001,7 @@ sub loadconfig {
                open($in, "<", $f) || die "mr: open $f: $!\n";
        }
        my @lines=<$in>;
                open($in, "<", $f) || die "mr: open $f: $!\n";
        }
        my @lines=<$in>;

-       close $in;
+       close $in unless ref $f eq 'GLOB';

 
        my $section;
        my $line=0;
 
        my $section;
        my $line=0;


@@ -1106,6 +1106,13 @@ sub loadconfig {
        }
 }
 
        }
 }
 

+sub startingconfig {
+       %alias=%config=%configfiles=%knownactions=%loaded=();
+       my $datapos=tell(DATA);
+       loadconfig(\*DATA);
+       seek(DATA,$datapos,0); # rewind
+}
+

 sub modifyconfig {
        my $f=shift;
        # the section to modify or add
 sub modifyconfig {
        my $f=shift;
        # the section to modify or add


@@ -1337,7 +1344,7 @@ sub bootstrap {
        die $@ if $@;
        my $tmpconfig=File::Temp->new();
        if (system("curl", "-A", "mr", "-s", $url, "-o", $tmpconfig) != 0) {
        die $@ if $@;
        my $tmpconfig=File::Temp->new();
        if (system("curl", "-A", "mr", "-s", $url, "-o", $tmpconfig) != 0) {

-               die "mr: download of $url failed\n";
+               die "mr bootstrap: download of $url failed\n";

        }
 
        if (! -e $dir) {
        }
 
        if (! -e $dir) {


@@ -1354,7 +1361,7 @@ sub bootstrap {
                if exists $config{$topdir}{"."}{"checkout"};
 
        if (-e ".mrconfig") {
                if exists $config{$topdir}{"."}{"checkout"};
 
        if (-e ".mrconfig") {

-               print STDERR "mr: .mrconfig file already exists, not overwriting with $url\n";
+               print STDERR "mr bootstrap: .mrconfig file already exists, not overwriting with $url\n";

        }
        else {
                eval q{use File::Copy};
        }
        else {
                eval q{use File::Copy};


@@ -1362,8 +1369,14 @@ sub bootstrap {
                move($tmpconfig, ".mrconfig") || die "rename: $!";
        }
 
                move($tmpconfig, ".mrconfig") || die "rename: $!";
        }
 

-       exec("mr $ENV{MR_SWITCHES} -c .mrconfig checkout");
-       die "failed to run mr checkout";
+       # Reload the config file (in case we got a different version)
+       # and checkout everything else.
+       startingconfig();
+       loadconfig(".mrconfig");
+       dispatch("checkout");
+       @skipped=grep { abs_path($_) ne abs_path($topdir) } @skipped;
+       showstats("bootstrap");
+       exitstats();

 }
 
 # alias expansion and command stemming
 }
 
 # alias expansion and command stemming


@@ -1451,28 +1464,32 @@ sub init {
                $ENV{MR_PATH}=$Bin."/".$Script;
        };
 }
                $ENV{MR_PATH}=$Bin."/".$Script;
        };
 }

+       
+sub exitstats {
+       if (@failed) {
+               exit 1;
+       }
+       elsif (! @ok && @skipped) {
+               exit 1;
+       }
+       else {
+               exit 0;
+       }
+}

 
 sub main {
        getopts();
        init();
 
 
 sub main {
        getopts();
        init();
 

-       loadconfig(\*DATA);
+       startingconfig();

        loadconfig($ENV{MR_CONFIG});
        #use Data::Dumper; print Dumper(\%config);
        
        my $action=expandaction(shift @ARGV);
        dispatch($action);
        loadconfig($ENV{MR_CONFIG});
        #use Data::Dumper; print Dumper(\%config);
        
        my $action=expandaction(shift @ARGV);
        dispatch($action);

-       showstats($action);

 
 

-       if (@failed) {
-               exit 1;
-       }
-       elsif (! @ok && @skipped) {
-               exit 1;
-       }
-       else {
-               exit 0;
-       }
+       showstats($action);
+       exitstats();

 }
 
 # Finally, some useful actions that mr knows about by default.
 }
 
 # Finally, some useful actions that mr knows about by default.