madduck's git repository

Every one of the projects in this repository is available at the canonical URL git://git.madduck.net/madduck/pub/<projectpath> — see each project's metadata for the exact URL.

All patches and comments are welcome. Please squash your changes to logical commits before using git-format-patch and git-send-email to patches@git.madduck.net. If you'd read over the Git project's submission guidelines and adhered to them, I'd be especially grateful.

SSH access, as well as push access can be individually arranged.

If you use my repositories frequently, consider adding the following snippet to ~/.gitconfig and using the third clone URL listed for each project:

[url "git://git.madduck.net/madduck/"]
  insteadOf = madduck:

task widget: Check if mouse is still over attached widget in aync show
authorNick Diego Yamane <nick.diego@gmail.com>
Thu, 17 Aug 2017 19:45:50 +0000 (15:45 -0400)
committerLuke Bonham <dada@archlinux.info>
Fri, 18 Aug 2017 09:35:26 +0000 (11:35 +0200)
This fixes issue #356. Using an approach similar
to what is implemented in other lain widgets (e.g:
calendar). That is, checking the mouse is still over
the target widget inside the `helpers.async` function
call in `task.show()`.

Signed-off-by: Nick Diego Yamane <nick.diego@gmail.com>
widget/contrib/task.lua

index 69d9fd09d2a497c172c86c43fefebaa1243a1f8e..302642e974299e7b97403ce2c19bb2b30eeaabc4 100644 (file)
@@ -10,6 +10,7 @@ local helpers = require("lain.helpers")
 local markup  = require("lain.util").markup
 local awful   = require("awful")
 local naughty = require("naughty")
+local mouse   = mouse
 local string  = { format = string.format, gsub = string.gsub }
 
 -- Taskwarrior notification
@@ -23,7 +24,6 @@ function task.hide()
 end
 
 function task.show(scr)
-    task.hide()
 
     if task.followtag then
         task.notification_preset.screen = awful.screen.focused()
@@ -32,12 +32,27 @@ function task.show(scr)
     end
 
     helpers.async({ awful.util.shell, "-c", task.show_cmd }, function(f)
-        task.notification = naughty.notify({
-            preset = task.notification_preset,
-            title  = "task next",
-            text   = markup.font(task.notification_preset.font,
-                     awful.util.escape(f:gsub("\n*$", "")))
-        })
+        local widget_focused = true
+
+        if mouse.current_widgets then
+            widget_focused = false
+            for _,v in ipairs(mouse.current_widgets) do
+                if task.widget == v then
+                    widget_focused = true
+                    break
+                end
+            end
+        end
+
+        if widget_focused then
+            task.hide()
+            task.notification = naughty.notify({
+                    preset = task.notification_preset,
+                    title  = "task next",
+                    text   = markup.font(task.notification_preset.font,
+                        awful.util.escape(f:gsub("\n*$", "")))
+                })
+        end
     end)
 end
 
@@ -65,6 +80,7 @@ function task.attach(widget, args)
     task.prompt_text         = args.prompt_text or "Enter task command: "
     task.followtag           = args.followtag or false
     task.notification_preset = args.notification_preset
+    task.widget              = widget
 
     if not task.notification_preset then
         task.notification_preset = {