Merge pull request #26 from mmedvede/add-quickfix-location

[etc/vim.git] / ftplugin / python_flake8.vim

diff --git a/ftplugin/python_flake8.vim b/ftplugin/python_flake8.vim
index 0b386c7689692974ab5e58c9fd53ef7e664eef6b..b26d9a1a75e05bc5d86efa9b479cf3138af526f2 100644 (file)
--- a/ftplugin/python_flake8.vim
+++ b/ftplugin/python_flake8.vim
@@ -11,29 +11,14 @@ if exists("b:loaded_flake8_ftplugin")
 endif
 let b:loaded_flake8_ftplugin=1
 
 endif
 let b:loaded_flake8_ftplugin=1
 

-if exists("g:flake8_cmd")
-    let s:flake8_cmd=g:flake8_cmd
-else
-    let s:flake8_cmd="flake8"
-endif
-
-let s:flake8_ignores=""
-if exists("g:flake8_ignore")
-    let s:flake8_ignores=" --ignore=".g:flake8_ignore
-endif
-
-let s:flake8_max_line_length=""
-if exists("g:flake8_max_line_length")
-    let s:flake8_max_line_length=" --max-line-length=".g:flake8_max_line_length
-endif
-
-let s:flake8_max_complexity=""
-if exists("g:flake8_max_complexity")
-    let s:flake8_max_complexity=" --max-complexity=".g:flake8_max_complexity
-endif
-

 if !exists("*Flake8()")
     function Flake8()
 if !exists("*Flake8()")
     function Flake8()

+        if exists("g:flake8_cmd")
+            let s:flake8_cmd=g:flake8_cmd
+        else
+            let s:flake8_cmd="flake8"
+        endif
+

         if !executable(s:flake8_cmd)
             echoerr "File " . s:flake8_cmd . " not found. Please install it first."
             return
         if !executable(s:flake8_cmd)
             echoerr "File " . s:flake8_cmd . " not found. Please install it first."
             return


@@ -51,10 +36,41 @@ if !exists("*Flake8()")
             update
         endif
 
             update
         endif
 

+        " read config
+        if exists("g:flake8_builtins")
+            let s:flake8_builtins_opt=" --builtins=".g:flake8_builtins
+        else
+            let s:flake8_builtins_opt=""
+        endif
+
+        if exists("g:flake8_ignore")
+            let s:flake8_ignores=" --ignore=".g:flake8_ignore
+        else
+            let s:flake8_ignores=""
+        endif
+
+        if exists("g:flake8_max_line_length")
+            let s:flake8_max_line_length=" --max-line-length=".g:flake8_max_line_length
+        else
+            let s:flake8_max_line_length=""
+        endif
+
+        if exists("g:flake8_max_complexity")
+            let s:flake8_max_complexity=" --max-complexity=".g:flake8_max_complexity
+        else
+            let s:flake8_max_complexity=""
+        endif
+
+        if exists("g:flake8_quickfix_location")
+            let s:flake8_quickfix_location=g:flake8_quickfix_location
+        else
+            let s:flake8_quickfix_location="belowright"
+        endif
+

         " perform the grep itself
         let &grepformat="%f:%l:%c: %m\,%f:%l: %m"
         " perform the grep itself
         let &grepformat="%f:%l:%c: %m\,%f:%l: %m"

-        let &grepprg=s:flake8_cmd.s:flake8_ignores.s:flake8_max_line_length.s:flake8_max_complexity
-        silent! grep! %
+        let &grepprg=s:flake8_cmd.s:flake8_builtins_opt.s:flake8_ignores.s:flake8_max_line_length.s:flake8_max_complexity
+        silent! grep! "%"

 
         " restore grep settings
         let &grepformat=l:old_gfm
 
         " restore grep settings
         let &grepformat=l:old_gfm


@@ -63,7 +79,7 @@ if !exists("*Flake8()")
         " open cwindow
         let has_results=getqflist() != []
         if has_results
         " open cwindow
         let has_results=getqflist() != []
         if has_results

-            execute 'belowright copen'
+            execute s:flake8_quickfix_location." copen"

             setlocal wrap
             nnoremap <buffer> <silent> c :cclose<CR>
             nnoremap <buffer> <silent> q :cclose<CR>
             setlocal wrap
             nnoremap <buffer> <silent> c :cclose<CR>
             nnoremap <buffer> <silent> q :cclose<CR>