]> git.madduck.net Git - etc/vim.git/commitdiff

madduck's git repository

Every one of the projects in this repository is available at the canonical URL git://git.madduck.net/madduck/pub/<projectpath> — see each project's metadata for the exact URL.

All patches and comments are welcome. Please squash your changes to logical commits before using git-format-patch and git-send-email to patches@git.madduck.net. If you'd read over the Git project's submission guidelines and adhered to them, I'd be especially grateful.

SSH access, as well as push access can be individually arranged.

If you use my repositories frequently, consider adding the following snippet to ~/.gitconfig and using the third clone URL listed for each project:

[url "git://git.madduck.net/madduck/"]
  insteadOf = madduck:

Report all stacktraces in verbose mode (#3938)
authorShantanu <12621235+hauntsaninja@users.noreply.github.com>
Tue, 10 Oct 2023 02:15:51 +0000 (19:15 -0700)
committerGitHub <noreply@github.com>
Tue, 10 Oct 2023 02:15:51 +0000 (19:15 -0700)
Previously these were swallowed (unlike the ones in black/__init__.py)

CHANGES.md
src/black/concurrency.py

index fe4b621a3e5781386b1d4841ae3e38d6e5f1db94..6ad6308945c6f203937e2d0c29d55c207dd21fcb 100644 (file)
@@ -44,6 +44,8 @@
 
 - Black no longer attempts to provide special errors for attempting to format Python 2
   code (#3933)
 
 - Black no longer attempts to provide special errors for attempting to format Python 2
   code (#3933)
+- Black will more consistently print stacktraces on internal errors in verbose mode
+  (#3938)
 
 ### _Blackd_
 
 
 ### _Blackd_
 
index ce01657839981794b5ee1a2995cf079ac74298c1..55c96b66c86e14fb4fb4b2a8f5aef54aa0e34dd3 100644 (file)
@@ -9,6 +9,7 @@ import logging
 import os
 import signal
 import sys
 import os
 import signal
 import sys
+import traceback
 from concurrent.futures import Executor, ProcessPoolExecutor, ThreadPoolExecutor
 from multiprocessing import Manager
 from pathlib import Path
 from concurrent.futures import Executor, ProcessPoolExecutor, ThreadPoolExecutor
 from multiprocessing import Manager
 from pathlib import Path
@@ -170,8 +171,10 @@ async def schedule_formatting(
             src = tasks.pop(task)
             if task.cancelled():
                 cancelled.append(task)
             src = tasks.pop(task)
             if task.cancelled():
                 cancelled.append(task)
-            elif task.exception():
-                report.failed(src, str(task.exception()))
+            elif exc := task.exception():
+                if report.verbose:
+                    traceback.print_exception(type(exc), exc, exc.__traceback__)
+                report.failed(src, str(exc))
             else:
                 changed = Changed.YES if task.result() else Changed.NO
                 # If the file was written back or was successfully checked as
             else:
                 changed = Changed.YES if task.result() else Changed.NO
                 # If the file was written back or was successfully checked as