]> git.madduck.net Git - etc/vim.git/blob - CONTRIBUTING.md

madduck's git repository

Every one of the projects in this repository is available at the canonical URL git://git.madduck.net/madduck/pub/<projectpath> — see each project's metadata for the exact URL.

All patches and comments are welcome. Please squash your changes to logical commits before using git-format-patch and git-send-email to patches@git.madduck.net. If you'd read over the Git project's submission guidelines and adhered to them, I'd be especially grateful.

SSH access, as well as push access can be individually arranged.

If you use my repositories frequently, consider adding the following snippet to ~/.gitconfig and using the third clone URL listed for each project:

[url "git://git.madduck.net/madduck/"]
  insteadOf = madduck:

Fix placement of dictionary unpacking inside dict literals
[etc/vim.git] / CONTRIBUTING.md
1 # Contributing to Black
2
3 Welcome! Happy to see you willing to make the project better. Have you
4 read the entire [user documentation](http://black.readthedocs.io/en/latest/)
5 yet?
6
7
8 ## Bird's eye view
9
10 In terms of inspiration, *Black* is about as configurable as *gofmt* and
11 *rustfmt* are.  This is deliberate.
12
13 Bug reports and fixes are always welcome!  Please follow the issue
14 template on GitHub for best results.
15
16 Before you suggest a new feature or configuration knob, ask yourself why
17 you want it.  If it enables better integration with some workflow, fixes
18 an inconsistency, speeds things up, and so on - go for it!  On the other
19 hand, if your answer is "because I don't like a particular formatting"
20 then you're not ready to embrace *Black* yet. Such changes are unlikely
21 to get accepted. You can still try but prepare to be disappointed.
22
23
24 ## Technicalities
25
26 Development on the latest version of Python is preferred.  As of this
27 writing it's 3.6.4.  You can use any operating system.  I am using macOS
28 myself and CentOS at work.
29
30 Install all development dependencies using:
31 ```
32 $ pipenv install --dev
33 $ pre-commit install
34 ```
35 If you haven't used `pipenv` before but are comfortable with virtualenvs,
36 just run `pip install pipenv` in the virtualenv you're already using and
37 invoke the command above from the cloned Black repo. It will do the
38 correct thing.
39
40 Before submitting pull requests, run tests with:
41 ```
42 $ python setup.py test
43 ```
44
45
46 ## Hygiene
47
48 If you're fixing a bug, add a test.  Run it first to confirm it fails,
49 then fix the bug, run it again to confirm it's really fixed.
50
51 If adding a new feature, add a test.  In fact, always add a test.  But
52 wait, before adding any large feature, first open an issue for us to
53 discuss the idea first.
54
55
56 ## Finally
57
58 Thanks again for your interest in improving the project!  You're taking
59 action when most people decide to sit and watch.