All patches and comments are welcome. Please squash your changes to logical
commits before using git-format-patch and git-send-email to
patches@git.madduck.net.
If you'd read over the Git project's submission guidelines and adhered to them,
I'd be especially grateful.
2 Parse Python code and perform AST validation.
7 from typing import Any, Iterable, Iterator, List, Set, Tuple, Type, Union
9 if sys.version_info < (3, 8):
10 from typing_extensions import Final
12 from typing import Final
15 from blib2to3.pytree import Node, Leaf
16 from blib2to3 import pygram
17 from blib2to3.pgen2 import driver
18 from blib2to3.pgen2.grammar import Grammar
19 from blib2to3.pgen2.parse import ParseError
21 from black.mode import TargetVersion, Feature, supports_feature
22 from black.nodes import syms
27 _IS_PYPY = platform.python_implementation() == "PyPy"
30 from typed_ast import ast3, ast27
32 # Either our python version is too low, or we're on pypy
33 if sys.version_info < (3, 7) or (sys.version_info < (3, 8) and not _IS_PYPY):
35 "The typed_ast package is required but not installed.\n"
36 "You can upgrade to Python 3.8+ or install typed_ast with\n"
37 "`python3 -m pip install typed-ast`.",
45 class InvalidInput(ValueError):
46 """Raised when input source code fails all parse attempts."""
49 def get_grammars(target_versions: Set[TargetVersion]) -> List[Grammar]:
50 if not target_versions:
51 # No target_version specified, so try all grammars.
54 pygram.python_grammar_no_print_statement_no_exec_statement_async_keywords,
56 pygram.python_grammar_no_print_statement_no_exec_statement,
57 # Python 2.7 with future print_function import
58 pygram.python_grammar_no_print_statement,
60 pygram.python_grammar,
63 if all(version.is_python2() for version in target_versions):
64 # Python 2-only code, so try Python 2 grammars.
66 # Python 2.7 with future print_function import
67 pygram.python_grammar_no_print_statement,
69 pygram.python_grammar,
72 # Python 3-compatible code, so only try Python 3 grammar.
74 if supports_feature(target_versions, Feature.PATTERN_MATCHING):
76 grammars.append(pygram.python_grammar_soft_keywords)
77 # If we have to parse both, try to parse async as a keyword first
78 if not supports_feature(target_versions, Feature.ASYNC_IDENTIFIERS):
81 pygram.python_grammar_no_print_statement_no_exec_statement_async_keywords
83 if not supports_feature(target_versions, Feature.ASYNC_KEYWORDS):
85 grammars.append(pygram.python_grammar_no_print_statement_no_exec_statement)
86 # At least one of the above branches must have been taken, because every Python
87 # version has exactly one of the two 'ASYNC_*' flags
91 def lib2to3_parse(src_txt: str, target_versions: Iterable[TargetVersion] = ()) -> Node:
92 """Given a string with source, return the lib2to3 Node."""
93 if not src_txt.endswith("\n"):
96 for grammar in get_grammars(set(target_versions)):
97 drv = driver.Driver(grammar)
99 result = drv.parse_string(src_txt, True)
102 except ParseError as pe:
103 lineno, column = pe.context[1]
104 lines = src_txt.splitlines()
106 faulty_line = lines[lineno - 1]
108 faulty_line = "<line number missing in source>"
109 exc = InvalidInput(f"Cannot parse: {lineno}:{column}: {faulty_line}")
113 if isinstance(result, Leaf):
114 result = Node(syms.file_input, [result])
118 def lib2to3_unparse(node: Node) -> str:
119 """Given a lib2to3 node, return its string representation."""
124 def parse_single_version(
125 src: str, version: Tuple[int, int]
126 ) -> Union[ast.AST, ast3.AST, ast27.AST]:
127 filename = "<unknown>"
128 # typed_ast is needed because of feature version limitations in the builtin ast
129 if sys.version_info >= (3, 8) and version >= (3,):
130 return ast.parse(src, filename, feature_version=version)
131 elif version >= (3,):
133 return ast3.parse(src, filename)
135 return ast3.parse(src, filename, feature_version=version[1])
136 elif version == (2, 7):
137 return ast27.parse(src)
138 raise AssertionError("INTERNAL ERROR: Tried parsing unsupported Python version!")
141 def parse_ast(src: str) -> Union[ast.AST, ast3.AST, ast27.AST]:
142 # TODO: support Python 4+ ;)
143 versions = [(3, minor) for minor in range(3, sys.version_info[1] + 1)]
145 if ast27.__name__ != "ast":
146 versions.append((2, 7))
149 for version in sorted(versions, reverse=True):
151 return parse_single_version(src, version)
152 except SyntaxError as e:
156 raise SyntaxError(first_error)
159 ast3_AST: Final[Type[ast3.AST]] = ast3.AST
160 ast27_AST: Final[Type[ast27.AST]] = ast27.AST
164 node: Union[ast.AST, ast3.AST, ast27.AST], depth: int = 0
166 """Simple visitor generating strings to compare ASTs by content."""
168 node = fixup_ast_constants(node)
170 yield f"{' ' * depth}{node.__class__.__name__}("
172 for field in sorted(node._fields): # noqa: F402
173 # TypeIgnore will not be present using pypy < 3.8, so need for this
174 if not (_IS_PYPY and sys.version_info < (3, 8)):
175 # TypeIgnore has only one field 'lineno' which breaks this comparison
176 type_ignore_classes = (ast3.TypeIgnore, ast27.TypeIgnore)
177 if sys.version_info >= (3, 8):
178 type_ignore_classes += (ast.TypeIgnore,)
179 if isinstance(node, type_ignore_classes):
183 value = getattr(node, field)
184 except AttributeError:
187 yield f"{' ' * (depth+1)}{field}="
189 if isinstance(value, list):
191 # Ignore nested tuples within del statements, because we may insert
192 # parentheses and they change the AST.
195 and isinstance(node, (ast.Delete, ast3.Delete, ast27.Delete))
196 and isinstance(item, (ast.Tuple, ast3.Tuple, ast27.Tuple))
198 for item in item.elts:
199 yield from stringify_ast(item, depth + 2)
201 elif isinstance(item, (ast.AST, ast3.AST, ast27.AST)):
202 yield from stringify_ast(item, depth + 2)
204 # Note that we are referencing the typed-ast ASTs via global variables and not
205 # direct module attribute accesses because that breaks mypyc. It's probably
206 # something to do with the ast3 / ast27 variables being marked as Any leading
207 # mypy to think this branch is always taken, leaving the rest of the code
208 # unanalyzed. Tighting up the types for the typed-ast AST types avoids the
210 elif isinstance(value, (ast.AST, ast3_AST, ast27_AST)):
211 yield from stringify_ast(value, depth + 2)
214 # Constant strings may be indented across newlines, if they are
215 # docstrings; fold spaces after newlines when comparing. Similarly,
216 # trailing and leading space may be removed.
217 # Note that when formatting Python 2 code, at least with Windows
218 # line-endings, docstrings can end up here as bytes instead of
219 # str so make sure that we handle both cases.
221 isinstance(node, ast.Constant)
223 and isinstance(value, (str, bytes))
225 lineend = "\n" if isinstance(value, str) else b"\n"
226 # To normalize, we strip any leading and trailing space from
228 stripped = [line.strip() for line in value.splitlines()]
229 normalized = lineend.join(stripped) # type: ignore[attr-defined]
230 # ...and remove any blank lines at the beginning and end of
232 normalized = normalized.strip()
235 yield f"{' ' * (depth+2)}{normalized!r}, # {value.__class__.__name__}"
237 yield f"{' ' * depth}) # /{node.__class__.__name__}"
240 def fixup_ast_constants(
241 node: Union[ast.AST, ast3.AST, ast27.AST]
242 ) -> Union[ast.AST, ast3.AST, ast27.AST]:
243 """Map ast nodes deprecated in 3.8 to Constant."""
244 if isinstance(node, (ast.Str, ast3.Str, ast27.Str, ast.Bytes, ast3.Bytes)):
245 return ast.Constant(value=node.s)
247 if isinstance(node, (ast.Num, ast3.Num, ast27.Num)):
248 return ast.Constant(value=node.n)
250 if isinstance(node, (ast.NameConstant, ast3.NameConstant)):
251 return ast.Constant(value=node.value)