All patches and comments are welcome. Please squash your changes to logical
commits before using git-format-patch and git-send-email to
patches@git.madduck.net.
If you'd read over the Git project's submission guidelines and adhered to them,
I'd be especially grateful.
2 Generating lines of code.
4 from functools import partial, wraps
6 from typing import Collection, Iterator, List, Optional, Set, Union
8 from dataclasses import dataclass, field
10 from black.nodes import WHITESPACE, RARROW, STATEMENT, STANDALONE_COMMENT
11 from black.nodes import ASSIGNMENTS, OPENING_BRACKETS, CLOSING_BRACKETS
12 from black.nodes import Visitor, syms, first_child_is_arith, ensure_visible
13 from black.nodes import is_docstring, is_empty_tuple, is_one_tuple, is_one_tuple_between
14 from black.nodes import is_walrus_assignment, is_yield, is_vararg, is_multiline_string
15 from black.nodes import is_stub_suite, is_stub_body, is_atom_with_invisible_parens
16 from black.nodes import wrap_in_parentheses
17 from black.brackets import max_delimiter_priority_in_atom
18 from black.brackets import DOT_PRIORITY, COMMA_PRIORITY
19 from black.lines import Line, line_to_string, is_line_short_enough
20 from black.lines import can_omit_invisible_parens, can_be_split, append_leaves
21 from black.comments import generate_comments, list_comments, FMT_OFF
22 from black.numerics import normalize_numeric_literal
23 from black.strings import get_string_prefix, fix_docstring
24 from black.strings import normalize_string_prefix, normalize_string_quotes
25 from black.trans import Transformer, CannotTransform, StringMerger
26 from black.trans import StringSplitter, StringParenWrapper, StringParenStripper
27 from black.mode import Mode
28 from black.mode import Feature
30 from blib2to3.pytree import Node, Leaf
31 from blib2to3.pgen2 import token
36 LN = Union[Leaf, Node]
39 class CannotSplit(CannotTransform):
40 """A readable split that fits the allotted line length is impossible."""
44 class LineGenerator(Visitor[Line]):
45 """Generates reformatted Line objects. Empty lines are not emitted.
47 Note: destroys the tree it's visiting by mutating prefixes of its leaves
48 in ways that will no longer stringify to valid Python code on the tree.
52 remove_u_prefix: bool = False
53 current_line: Line = field(init=False)
55 def line(self, indent: int = 0) -> Iterator[Line]:
58 If the line is empty, only emit if it makes sense.
59 If the line is too long, split it first and then generate.
61 If any lines were generated, set up a new current_line.
63 if not self.current_line:
64 self.current_line.depth += indent
65 return # Line is empty, don't emit. Creating a new one unnecessary.
67 complete_line = self.current_line
68 self.current_line = Line(mode=self.mode, depth=complete_line.depth + indent)
71 def visit_default(self, node: LN) -> Iterator[Line]:
72 """Default `visit_*()` implementation. Recurses to children of `node`."""
73 if isinstance(node, Leaf):
74 any_open_brackets = self.current_line.bracket_tracker.any_open_brackets()
75 for comment in generate_comments(node):
77 # any comment within brackets is subject to splitting
78 self.current_line.append(comment)
79 elif comment.type == token.COMMENT:
80 # regular trailing comment
81 self.current_line.append(comment)
82 yield from self.line()
85 # regular standalone comment
86 yield from self.line()
88 self.current_line.append(comment)
89 yield from self.line()
91 normalize_prefix(node, inside_brackets=any_open_brackets)
92 if self.mode.string_normalization and node.type == token.STRING:
93 node.value = normalize_string_prefix(
94 node.value, remove_u_prefix=self.remove_u_prefix
96 node.value = normalize_string_quotes(node.value)
97 if node.type == token.NUMBER:
98 normalize_numeric_literal(node)
99 if node.type not in WHITESPACE:
100 self.current_line.append(node)
101 yield from super().visit_default(node)
103 def visit_INDENT(self, node: Leaf) -> Iterator[Line]:
104 """Increase indentation level, maybe yield a line."""
105 # In blib2to3 INDENT never holds comments.
106 yield from self.line(+1)
107 yield from self.visit_default(node)
109 def visit_DEDENT(self, node: Leaf) -> Iterator[Line]:
110 """Decrease indentation level, maybe yield a line."""
111 # The current line might still wait for trailing comments. At DEDENT time
112 # there won't be any (they would be prefixes on the preceding NEWLINE).
113 # Emit the line then.
114 yield from self.line()
116 # While DEDENT has no value, its prefix may contain standalone comments
117 # that belong to the current indentation level. Get 'em.
118 yield from self.visit_default(node)
120 # Finally, emit the dedent.
121 yield from self.line(-1)
124 self, node: Node, keywords: Set[str], parens: Set[str]
126 """Visit a statement.
128 This implementation is shared for `if`, `while`, `for`, `try`, `except`,
129 `def`, `with`, `class`, `assert`, `match`, `case` and assignments.
131 The relevant Python language `keywords` for a given statement will be
132 NAME leaves within it. This methods puts those on a separate line.
134 `parens` holds a set of string leaf values immediately after which
135 invisible parens should be put.
137 normalize_invisible_parens(node, parens_after=parens)
138 for child in node.children:
139 if child.type == token.NAME and child.value in keywords: # type: ignore
140 yield from self.line()
142 yield from self.visit(child)
144 def visit_suite(self, node: Node) -> Iterator[Line]:
146 if self.mode.is_pyi and is_stub_suite(node):
147 yield from self.visit(node.children[2])
149 yield from self.visit_default(node)
151 def visit_simple_stmt(self, node: Node) -> Iterator[Line]:
152 """Visit a statement without nested statements."""
153 if first_child_is_arith(node):
154 wrap_in_parentheses(node, node.children[0], visible=False)
155 is_suite_like = node.parent and node.parent.type in STATEMENT
157 if self.mode.is_pyi and is_stub_body(node):
158 yield from self.visit_default(node)
160 yield from self.line(+1)
161 yield from self.visit_default(node)
162 yield from self.line(-1)
168 or not is_stub_suite(node.parent)
170 yield from self.line()
171 yield from self.visit_default(node)
173 def visit_async_stmt(self, node: Node) -> Iterator[Line]:
174 """Visit `async def`, `async for`, `async with`."""
175 yield from self.line()
177 children = iter(node.children)
178 for child in children:
179 yield from self.visit(child)
181 if child.type == token.ASYNC:
184 internal_stmt = next(children)
185 for child in internal_stmt.children:
186 yield from self.visit(child)
188 def visit_decorators(self, node: Node) -> Iterator[Line]:
189 """Visit decorators."""
190 for child in node.children:
191 yield from self.line()
192 yield from self.visit(child)
194 def visit_SEMI(self, leaf: Leaf) -> Iterator[Line]:
195 """Remove a semicolon and put the other statement on a separate line."""
196 yield from self.line()
198 def visit_ENDMARKER(self, leaf: Leaf) -> Iterator[Line]:
199 """End of file. Process outstanding comments and end with a newline."""
200 yield from self.visit_default(leaf)
201 yield from self.line()
203 def visit_STANDALONE_COMMENT(self, leaf: Leaf) -> Iterator[Line]:
204 if not self.current_line.bracket_tracker.any_open_brackets():
205 yield from self.line()
206 yield from self.visit_default(leaf)
208 def visit_factor(self, node: Node) -> Iterator[Line]:
209 """Force parentheses between a unary op and a binary power:
213 _operator, operand = node.children
215 operand.type == syms.power
216 and len(operand.children) == 3
217 and operand.children[1].type == token.DOUBLESTAR
219 lpar = Leaf(token.LPAR, "(")
220 rpar = Leaf(token.RPAR, ")")
221 index = operand.remove() or 0
222 node.insert_child(index, Node(syms.atom, [lpar, operand, rpar]))
223 yield from self.visit_default(node)
225 def visit_STRING(self, leaf: Leaf) -> Iterator[Line]:
226 if is_docstring(leaf) and "\\\n" not in leaf.value:
227 # We're ignoring docstrings with backslash newline escapes because changing
228 # indentation of those changes the AST representation of the code.
229 docstring = normalize_string_prefix(leaf.value, self.remove_u_prefix)
230 prefix = get_string_prefix(docstring)
231 docstring = docstring[len(prefix) :] # Remove the prefix
232 quote_char = docstring[0]
233 # A natural way to remove the outer quotes is to do:
234 # docstring = docstring.strip(quote_char)
235 # but that breaks on """""x""" (which is '""x').
236 # So we actually need to remove the first character and the next two
237 # characters but only if they are the same as the first.
238 quote_len = 1 if docstring[1] != quote_char else 3
239 docstring = docstring[quote_len:-quote_len]
240 docstring_started_empty = not docstring
242 if is_multiline_string(leaf):
243 indent = " " * 4 * self.current_line.depth
244 docstring = fix_docstring(docstring, indent)
246 docstring = docstring.strip()
249 # Add some padding if the docstring starts / ends with a quote mark.
250 if docstring[0] == quote_char:
251 docstring = " " + docstring
252 if docstring[-1] == quote_char:
254 if docstring[-1] == "\\":
255 backslash_count = len(docstring) - len(docstring.rstrip("\\"))
256 if backslash_count % 2:
257 # Odd number of tailing backslashes, add some padding to
258 # avoid escaping the closing string quote.
260 elif not docstring_started_empty:
263 # We could enforce triple quotes at this point.
264 quote = quote_char * quote_len
265 leaf.value = prefix + quote + docstring + quote
267 yield from self.visit_default(leaf)
269 def __post_init__(self) -> None:
270 """You are in a twisty little maze of passages."""
271 self.current_line = Line(mode=self.mode)
275 self.visit_assert_stmt = partial(v, keywords={"assert"}, parens={"assert", ","})
276 self.visit_if_stmt = partial(
277 v, keywords={"if", "else", "elif"}, parens={"if", "elif"}
279 self.visit_while_stmt = partial(v, keywords={"while", "else"}, parens={"while"})
280 self.visit_for_stmt = partial(v, keywords={"for", "else"}, parens={"for", "in"})
281 self.visit_try_stmt = partial(
282 v, keywords={"try", "except", "else", "finally"}, parens=Ø
284 self.visit_except_clause = partial(v, keywords={"except"}, parens=Ø)
285 self.visit_with_stmt = partial(v, keywords={"with"}, parens=Ø)
286 self.visit_funcdef = partial(v, keywords={"def"}, parens=Ø)
287 self.visit_classdef = partial(v, keywords={"class"}, parens=Ø)
288 self.visit_expr_stmt = partial(v, keywords=Ø, parens=ASSIGNMENTS)
289 self.visit_return_stmt = partial(v, keywords={"return"}, parens={"return"})
290 self.visit_import_from = partial(v, keywords=Ø, parens={"import"})
291 self.visit_del_stmt = partial(v, keywords=Ø, parens={"del"})
292 self.visit_async_funcdef = self.visit_async_stmt
293 self.visit_decorated = self.visit_decorators
296 self.visit_match_stmt = partial(v, keywords={"match"}, parens=Ø)
297 self.visit_case_block = partial(v, keywords={"case"}, parens=Ø)
301 line: Line, mode: Mode, features: Collection[Feature] = ()
303 """Transform a `line`, potentially splitting it into many lines.
305 They should fit in the allotted `line_length` but might not be able to.
307 `features` are syntactical features that may be used in the output.
313 line_str = line_to_string(line)
315 ll = mode.line_length
316 sn = mode.string_normalization
317 string_merge = StringMerger(ll, sn)
318 string_paren_strip = StringParenStripper(ll, sn)
319 string_split = StringSplitter(ll, sn)
320 string_paren_wrap = StringParenWrapper(ll, sn)
322 transformers: List[Transformer]
324 not line.contains_uncollapsable_type_comments()
325 and not line.should_split_rhs
326 and not line.magic_trailing_comma
328 is_line_short_enough(line, line_length=mode.line_length, line_str=line_str)
329 or line.contains_unsplittable_type_ignore()
331 and not (line.inside_brackets and line.contains_standalone_comments())
333 # Only apply basic string preprocessing, since lines shouldn't be split here.
334 if mode.experimental_string_processing:
335 transformers = [string_merge, string_paren_strip]
339 transformers = [left_hand_split]
342 def rhs(line: Line, features: Collection[Feature]) -> Iterator[Line]:
343 """Wraps calls to `right_hand_split`.
345 The calls increasingly `omit` right-hand trailers (bracket pairs with
346 content), meaning the trailers get glued together to split on another
347 bracket pair instead.
349 for omit in generate_trailers_to_omit(line, mode.line_length):
351 right_hand_split(line, mode.line_length, features, omit=omit)
353 # Note: this check is only able to figure out if the first line of the
354 # *current* transformation fits in the line length. This is true only
355 # for simple cases. All others require running more transforms via
356 # `transform_line()`. This check doesn't know if those would succeed.
357 if is_line_short_enough(lines[0], line_length=mode.line_length):
361 # All splits failed, best effort split with no omits.
362 # This mostly happens to multiline strings that are by definition
363 # reported as not fitting a single line, as well as lines that contain
364 # trailing commas (those have to be exploded).
365 yield from right_hand_split(
366 line, line_length=mode.line_length, features=features
369 if mode.experimental_string_processing:
370 if line.inside_brackets:
376 standalone_comment_split,
389 if line.inside_brackets:
390 transformers = [delimiter_split, standalone_comment_split, rhs]
394 for transform in transformers:
395 # We are accumulating lines in `result` because we might want to abort
396 # mission and return the original line in the end, or attempt a different
399 result = run_transformer(line, transform, mode, features, line_str=line_str)
400 except CannotTransform:
410 def left_hand_split(line: Line, _features: Collection[Feature] = ()) -> Iterator[Line]:
411 """Split line into many lines, starting with the first matching bracket pair.
413 Note: this usually looks weird, only use this for function definitions.
414 Prefer RHS otherwise. This is why this function is not symmetrical with
415 :func:`right_hand_split` which also handles optional parentheses.
417 tail_leaves: List[Leaf] = []
418 body_leaves: List[Leaf] = []
419 head_leaves: List[Leaf] = []
420 current_leaves = head_leaves
421 matching_bracket: Optional[Leaf] = None
422 for leaf in line.leaves:
424 current_leaves is body_leaves
425 and leaf.type in CLOSING_BRACKETS
426 and leaf.opening_bracket is matching_bracket
428 current_leaves = tail_leaves if body_leaves else head_leaves
429 current_leaves.append(leaf)
430 if current_leaves is head_leaves:
431 if leaf.type in OPENING_BRACKETS:
432 matching_bracket = leaf
433 current_leaves = body_leaves
434 if not matching_bracket:
435 raise CannotSplit("No brackets found")
437 head = bracket_split_build_line(head_leaves, line, matching_bracket)
438 body = bracket_split_build_line(body_leaves, line, matching_bracket, is_body=True)
439 tail = bracket_split_build_line(tail_leaves, line, matching_bracket)
440 bracket_split_succeeded_or_raise(head, body, tail)
441 for result in (head, body, tail):
446 def right_hand_split(
449 features: Collection[Feature] = (),
450 omit: Collection[LeafID] = (),
452 """Split line into many lines, starting with the last matching bracket pair.
454 If the split was by optional parentheses, attempt splitting without them, too.
455 `omit` is a collection of closing bracket IDs that shouldn't be considered for
458 Note: running this function modifies `bracket_depth` on the leaves of `line`.
460 tail_leaves: List[Leaf] = []
461 body_leaves: List[Leaf] = []
462 head_leaves: List[Leaf] = []
463 current_leaves = tail_leaves
464 opening_bracket: Optional[Leaf] = None
465 closing_bracket: Optional[Leaf] = None
466 for leaf in reversed(line.leaves):
467 if current_leaves is body_leaves:
468 if leaf is opening_bracket:
469 current_leaves = head_leaves if body_leaves else tail_leaves
470 current_leaves.append(leaf)
471 if current_leaves is tail_leaves:
472 if leaf.type in CLOSING_BRACKETS and id(leaf) not in omit:
473 opening_bracket = leaf.opening_bracket
474 closing_bracket = leaf
475 current_leaves = body_leaves
476 if not (opening_bracket and closing_bracket and head_leaves):
477 # If there is no opening or closing_bracket that means the split failed and
478 # all content is in the tail. Otherwise, if `head_leaves` are empty, it means
479 # the matching `opening_bracket` wasn't available on `line` anymore.
480 raise CannotSplit("No brackets found")
482 tail_leaves.reverse()
483 body_leaves.reverse()
484 head_leaves.reverse()
485 head = bracket_split_build_line(head_leaves, line, opening_bracket)
486 body = bracket_split_build_line(body_leaves, line, opening_bracket, is_body=True)
487 tail = bracket_split_build_line(tail_leaves, line, opening_bracket)
488 bracket_split_succeeded_or_raise(head, body, tail)
490 Feature.FORCE_OPTIONAL_PARENTHESES not in features
491 # the opening bracket is an optional paren
492 and opening_bracket.type == token.LPAR
493 and not opening_bracket.value
494 # the closing bracket is an optional paren
495 and closing_bracket.type == token.RPAR
496 and not closing_bracket.value
497 # it's not an import (optional parens are the only thing we can split on
498 # in this case; attempting a split without them is a waste of time)
499 and not line.is_import
500 # there are no standalone comments in the body
501 and not body.contains_standalone_comments(0)
502 # and we can actually remove the parens
503 and can_omit_invisible_parens(body, line_length, omit_on_explode=omit)
505 omit = {id(closing_bracket), *omit}
507 yield from right_hand_split(line, line_length, features=features, omit=omit)
510 except CannotSplit as e:
513 or is_line_short_enough(body, line_length=line_length)
516 "Splitting failed, body is still too long and can't be split."
519 elif head.contains_multiline_strings() or tail.contains_multiline_strings():
521 "The current optional pair of parentheses is bound to fail to"
522 " satisfy the splitting algorithm because the head or the tail"
523 " contains multiline strings which by definition never fit one"
527 ensure_visible(opening_bracket)
528 ensure_visible(closing_bracket)
529 for result in (head, body, tail):
534 def bracket_split_succeeded_or_raise(head: Line, body: Line, tail: Line) -> None:
535 """Raise :exc:`CannotSplit` if the last left- or right-hand split failed.
537 Do nothing otherwise.
539 A left- or right-hand split is based on a pair of brackets. Content before
540 (and including) the opening bracket is left on one line, content inside the
541 brackets is put on a separate line, and finally content starting with and
542 following the closing bracket is put on a separate line.
544 Those are called `head`, `body`, and `tail`, respectively. If the split
545 produced the same line (all content in `head`) or ended up with an empty `body`
546 and the `tail` is just the closing bracket, then it's considered failed.
548 tail_len = len(str(tail).strip())
551 raise CannotSplit("Splitting brackets produced the same line")
555 f"Splitting brackets on an empty body to save {tail_len} characters is"
560 def bracket_split_build_line(
561 leaves: List[Leaf], original: Line, opening_bracket: Leaf, *, is_body: bool = False
563 """Return a new line with given `leaves` and respective comments from `original`.
565 If `is_body` is True, the result line is one-indented inside brackets and as such
566 has its first leaf's prefix normalized and a trailing comma added when expected.
568 result = Line(mode=original.mode, depth=original.depth)
570 result.inside_brackets = True
573 # Since body is a new indent level, remove spurious leading whitespace.
574 normalize_prefix(leaves[0], inside_brackets=True)
575 # Ensure a trailing comma for imports and standalone function arguments, but
576 # be careful not to add one after any comments or within type annotations.
579 and opening_bracket.value == "("
580 and not any(leaf.type == token.COMMA for leaf in leaves)
581 # In particular, don't add one within a parenthesized return annotation.
582 # Unfortunately the indicator we're in a return annotation (RARROW) may
583 # be defined directly in the parent node, the parent of the parent ...
584 # and so on depending on how complex the return annotation is.
585 # This isn't perfect and there's some false negatives but they are in
586 # contexts were a comma is actually fine.
588 node.prev_sibling.type == RARROW
591 getattr(leaves[0].parent, "parent", None),
593 if isinstance(node, Node) and isinstance(node.prev_sibling, Leaf)
597 if original.is_import or no_commas:
598 for i in range(len(leaves) - 1, -1, -1):
599 if leaves[i].type == STANDALONE_COMMENT:
602 if leaves[i].type != token.COMMA:
603 new_comma = Leaf(token.COMMA, ",")
604 leaves.insert(i + 1, new_comma)
609 result.append(leaf, preformatted=True)
610 for comment_after in original.comments_after(leaf):
611 result.append(comment_after, preformatted=True)
612 if is_body and should_split_line(result, opening_bracket):
613 result.should_split_rhs = True
617 def dont_increase_indentation(split_func: Transformer) -> Transformer:
618 """Normalize prefix of the first leaf in every line returned by `split_func`.
620 This is a decorator over relevant split functions.
624 def split_wrapper(line: Line, features: Collection[Feature] = ()) -> Iterator[Line]:
625 for line in split_func(line, features):
626 normalize_prefix(line.leaves[0], inside_brackets=True)
632 @dont_increase_indentation
633 def delimiter_split(line: Line, features: Collection[Feature] = ()) -> Iterator[Line]:
634 """Split according to delimiters of the highest priority.
636 If the appropriate Features are given, the split will add trailing commas
637 also in function signatures and calls that contain `*` and `**`.
640 last_leaf = line.leaves[-1]
642 raise CannotSplit("Line empty") from None
644 bt = line.bracket_tracker
646 delimiter_priority = bt.max_delimiter_priority(exclude={id(last_leaf)})
648 raise CannotSplit("No delimiters found") from None
650 if delimiter_priority == DOT_PRIORITY:
651 if bt.delimiter_count_with_priority(delimiter_priority) == 1:
652 raise CannotSplit("Splitting a single attribute from its owner looks wrong")
655 mode=line.mode, depth=line.depth, inside_brackets=line.inside_brackets
657 lowest_depth = sys.maxsize
658 trailing_comma_safe = True
660 def append_to_line(leaf: Leaf) -> Iterator[Line]:
661 """Append `leaf` to current line or to new line if appending impossible."""
662 nonlocal current_line
664 current_line.append_safe(leaf, preformatted=True)
669 mode=line.mode, depth=line.depth, inside_brackets=line.inside_brackets
671 current_line.append(leaf)
673 for leaf in line.leaves:
674 yield from append_to_line(leaf)
676 for comment_after in line.comments_after(leaf):
677 yield from append_to_line(comment_after)
679 lowest_depth = min(lowest_depth, leaf.bracket_depth)
680 if leaf.bracket_depth == lowest_depth:
681 if is_vararg(leaf, within={syms.typedargslist}):
682 trailing_comma_safe = (
683 trailing_comma_safe and Feature.TRAILING_COMMA_IN_DEF in features
685 elif is_vararg(leaf, within={syms.arglist, syms.argument}):
686 trailing_comma_safe = (
687 trailing_comma_safe and Feature.TRAILING_COMMA_IN_CALL in features
690 leaf_priority = bt.delimiters.get(id(leaf))
691 if leaf_priority == delimiter_priority:
695 mode=line.mode, depth=line.depth, inside_brackets=line.inside_brackets
700 and delimiter_priority == COMMA_PRIORITY
701 and current_line.leaves[-1].type != token.COMMA
702 and current_line.leaves[-1].type != STANDALONE_COMMENT
704 new_comma = Leaf(token.COMMA, ",")
705 current_line.append(new_comma)
709 @dont_increase_indentation
710 def standalone_comment_split(
711 line: Line, features: Collection[Feature] = ()
713 """Split standalone comments from the rest of the line."""
714 if not line.contains_standalone_comments(0):
715 raise CannotSplit("Line does not have any standalone comments")
718 mode=line.mode, depth=line.depth, inside_brackets=line.inside_brackets
721 def append_to_line(leaf: Leaf) -> Iterator[Line]:
722 """Append `leaf` to current line or to new line if appending impossible."""
723 nonlocal current_line
725 current_line.append_safe(leaf, preformatted=True)
730 line.mode, depth=line.depth, inside_brackets=line.inside_brackets
732 current_line.append(leaf)
734 for leaf in line.leaves:
735 yield from append_to_line(leaf)
737 for comment_after in line.comments_after(leaf):
738 yield from append_to_line(comment_after)
744 def normalize_prefix(leaf: Leaf, *, inside_brackets: bool) -> None:
745 """Leave existing extra newlines if not `inside_brackets`. Remove everything
748 Note: don't use backslashes for formatting or you'll lose your voting rights.
750 if not inside_brackets:
751 spl = leaf.prefix.split("#")
752 if "\\" not in spl[0]:
753 nl_count = spl[-1].count("\n")
756 leaf.prefix = "\n" * nl_count
762 def normalize_invisible_parens(node: Node, parens_after: Set[str]) -> None:
763 """Make existing optional parentheses invisible or create new ones.
765 `parens_after` is a set of string leaf values immediately after which parens
768 Standardizes on visible parentheses for single-element tuples, and keeps
769 existing visible parentheses for other tuples and generator expressions.
771 for pc in list_comments(node.prefix, is_endmarker=False):
772 if pc.value in FMT_OFF:
773 # This `node` has a prefix with `# fmt: off`, don't mess with parens.
776 for index, child in enumerate(list(node.children)):
777 # Fixes a bug where invisible parens are not properly stripped from
778 # assignment statements that contain type annotations.
779 if isinstance(child, Node) and child.type == syms.annassign:
780 normalize_invisible_parens(child, parens_after=parens_after)
782 # Add parentheses around long tuple unpacking in assignments.
785 and isinstance(child, Node)
786 and child.type == syms.testlist_star_expr
791 if child.type == syms.atom:
792 if maybe_make_parens_invisible_in_atom(child, parent=node):
793 wrap_in_parentheses(node, child, visible=False)
794 elif is_one_tuple(child):
795 wrap_in_parentheses(node, child, visible=True)
796 elif node.type == syms.import_from:
797 # "import from" nodes store parentheses directly as part of
799 if child.type == token.LPAR:
800 # make parentheses invisible
801 child.value = "" # type: ignore
802 node.children[-1].value = "" # type: ignore
803 elif child.type != token.STAR:
804 # insert invisible parentheses
805 node.insert_child(index, Leaf(token.LPAR, ""))
806 node.append_child(Leaf(token.RPAR, ""))
809 elif not (isinstance(child, Leaf) and is_multiline_string(child)):
810 wrap_in_parentheses(node, child, visible=False)
812 check_lpar = isinstance(child, Leaf) and child.value in parens_after
815 def maybe_make_parens_invisible_in_atom(node: LN, parent: LN) -> bool:
816 """If it's safe, make the parens in the atom `node` invisible, recursively.
817 Additionally, remove repeated, adjacent invisible parens from the atom `node`
818 as they are redundant.
820 Returns whether the node should itself be wrapped in invisible parentheses.
825 node.type != syms.atom
826 or is_empty_tuple(node)
827 or is_one_tuple(node)
828 or (is_yield(node) and parent.type != syms.expr_stmt)
829 or max_delimiter_priority_in_atom(node) >= COMMA_PRIORITY
833 if is_walrus_assignment(node):
839 # these ones aren't useful to end users, but they do please fuzzers
845 first = node.children[0]
846 last = node.children[-1]
847 if first.type == token.LPAR and last.type == token.RPAR:
848 middle = node.children[1]
849 # make parentheses invisible
850 first.value = "" # type: ignore
851 last.value = "" # type: ignore
852 maybe_make_parens_invisible_in_atom(middle, parent=parent)
854 if is_atom_with_invisible_parens(middle):
855 # Strip the invisible parens from `middle` by replacing
856 # it with the child in-between the invisible parens
857 middle.replace(middle.children[1])
864 def should_split_line(line: Line, opening_bracket: Leaf) -> bool:
865 """Should `line` be immediately split with `delimiter_split()` after RHS?"""
867 if not (opening_bracket.parent and opening_bracket.value in "[{("):
870 # We're essentially checking if the body is delimited by commas and there's more
871 # than one of them (we're excluding the trailing comma and if the delimiter priority
872 # is still commas, that means there's more).
874 trailing_comma = False
876 last_leaf = line.leaves[-1]
877 if last_leaf.type == token.COMMA:
878 trailing_comma = True
879 exclude.add(id(last_leaf))
880 max_priority = line.bracket_tracker.max_delimiter_priority(exclude=exclude)
881 except (IndexError, ValueError):
884 return max_priority == COMMA_PRIORITY and (
885 (line.mode.magic_trailing_comma and trailing_comma)
886 # always explode imports
887 or opening_bracket.parent.type in {syms.atom, syms.import_from}
891 def generate_trailers_to_omit(line: Line, line_length: int) -> Iterator[Set[LeafID]]:
892 """Generate sets of closing bracket IDs that should be omitted in a RHS.
894 Brackets can be omitted if the entire trailer up to and including
895 a preceding closing bracket fits in one line.
897 Yielded sets are cumulative (contain results of previous yields, too). First
898 set is empty, unless the line should explode, in which case bracket pairs until
899 the one that needs to explode are omitted.
902 omit: Set[LeafID] = set()
903 if not line.magic_trailing_comma:
906 length = 4 * line.depth
907 opening_bracket: Optional[Leaf] = None
908 closing_bracket: Optional[Leaf] = None
909 inner_brackets: Set[LeafID] = set()
910 for index, leaf, leaf_length in line.enumerate_with_length(reversed=True):
911 length += leaf_length
912 if length > line_length:
915 has_inline_comment = leaf_length > len(leaf.value) + len(leaf.prefix)
916 if leaf.type == STANDALONE_COMMENT or has_inline_comment:
920 if leaf is opening_bracket:
921 opening_bracket = None
922 elif leaf.type in CLOSING_BRACKETS:
923 prev = line.leaves[index - 1] if index > 0 else None
926 and prev.type == token.COMMA
927 and not is_one_tuple_between(
928 leaf.opening_bracket, leaf, line.leaves
931 # Never omit bracket pairs with trailing commas.
932 # We need to explode on those.
935 inner_brackets.add(id(leaf))
936 elif leaf.type in CLOSING_BRACKETS:
937 prev = line.leaves[index - 1] if index > 0 else None
938 if prev and prev.type in OPENING_BRACKETS:
939 # Empty brackets would fail a split so treat them as "inner"
940 # brackets (e.g. only add them to the `omit` set if another
941 # pair of brackets was good enough.
942 inner_brackets.add(id(leaf))
946 omit.add(id(closing_bracket))
947 omit.update(inner_brackets)
948 inner_brackets.clear()
953 and prev.type == token.COMMA
954 and not is_one_tuple_between(leaf.opening_bracket, leaf, line.leaves)
956 # Never omit bracket pairs with trailing commas.
957 # We need to explode on those.
961 opening_bracket = leaf.opening_bracket
962 closing_bracket = leaf
967 transform: Transformer,
969 features: Collection[Feature],
974 line_str = line_to_string(line)
975 result: List[Line] = []
976 for transformed_line in transform(line, features):
977 if str(transformed_line).strip("\n") == line_str:
978 raise CannotTransform("Line transformer returned an unchanged result")
980 result.extend(transform_line(transformed_line, mode=mode, features=features))
983 transform.__name__ != "rhs"
984 or not line.bracket_tracker.invisible
985 or any(bracket.value for bracket in line.bracket_tracker.invisible)
986 or line.contains_multiline_strings()
987 or result[0].contains_uncollapsable_type_comments()
988 or result[0].contains_unsplittable_type_ignore()
989 or is_line_short_enough(result[0], line_length=mode.line_length)
990 # If any leaves have no parents (which _can_ occur since
991 # `transform(line)` potentially destroys the line's underlying node
992 # structure), then we can't proceed. Doing so would cause the below
993 # call to `append_leaves()` to fail.
994 or any(leaf.parent is None for leaf in line.leaves)
998 line_copy = line.clone()
999 append_leaves(line_copy, line, line.leaves)
1000 features_fop = set(features) | {Feature.FORCE_OPTIONAL_PARENTHESES}
1001 second_opinion = run_transformer(
1002 line_copy, transform, mode, features_fop, line_str=line_str
1005 is_line_short_enough(ln, line_length=mode.line_length) for ln in second_opinion
1007 result = second_opinion