All patches and comments are welcome. Please squash your changes to logical
commits before using git-format-patch and git-send-email to
patches@git.madduck.net.
If you'd read over the Git project's submission guidelines and adhered to them,
I'd be especially grateful.
2 Save g:ale_ruby_reek_show_context
3 Save g:ale_ruby_reek_show_wiki_link
5 let g:ale_ruby_reek_show_context = 0
6 let g:ale_ruby_reek_show_wiki_link = 0
8 runtime ale_linters/ruby/reek.vim
13 call ale#linter#Reset()
15 Execute(The reek handler should parse JSON correctly, with only context enabled):
16 let g:ale_ruby_reek_show_context = 1
22 \ 'text': 'Context#method violates rule number one',
28 \ 'text': 'Context#method violates rule number two',
34 \ 'text': 'Context#method violates rule number two',
39 \ ale_linters#ruby#reek#Handle(347, [
40 \ '[{"context":"Context#method","lines":[12],"message":"violates rule number one","smell_type":"Rule1","source":"/home/user/file.rb","parameter":"bad parameter","wiki_link":"https://example.com/Rule1.md"},{"context":"Context#method","lines":[34, 56],"message":"violates rule number two","smell_type":"Rule2","source":"/home/user/file.rb","name":"bad code","count":2,"wiki_link":"https://example.com/Rule1.md"}]'
43 Execute(The reek handler should parse JSON correctly, with no context or wiki links):
48 \ 'text': 'violates rule number one',
53 \ ale_linters#ruby#reek#Handle(347, [
54 \ '[{"context":"Context#method","lines":[12],"message":"violates rule number one","smell_type":"Rule1","source":"/home/user/file.rb","parameter":"bad parameter","wiki_link":"https://example.com/Rule1.md"}]'
57 Execute(The reek handler should parse JSON correctly, with both context and wiki links):
58 let g:ale_ruby_reek_show_context = 1
59 let g:ale_ruby_reek_show_wiki_link = 1
65 \ 'text': 'Context#method violates rule number one [https://example.com/Rule1.md]',
70 \ ale_linters#ruby#reek#Handle(347, [
71 \ '[{"context":"Context#method","lines":[12],"message":"violates rule number one","smell_type":"Rule1","source":"/home/user/file.rb","parameter":"bad parameter","wiki_link":"https://example.com/Rule1.md"}]'
74 Execute(The reek handler should parse JSON correctly when there is no output from reek):
77 \ ale_linters#ruby#reek#Handle(347, [
80 Execute(The reek handler should handle garbage output):
83 \ ale_linters#ruby#reek#Handle(347, [
84 \ 'No such command in 2.4.1 of ruby',